Add support for Azure Linux 4 to chrony, kdump, kill, modprobe, dhclient tools#4570
Open
bhagyapathak wants to merge 2 commits into
Open
Add support for Azure Linux 4 to chrony, kdump, kill, modprobe, dhclient tools#4570bhagyapathak wants to merge 2 commits into
bhagyapathak wants to merge 2 commits into
Conversation
✅ AI Test Selection — PASSED6 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several LISA “tools” to better support Azure Linux 4 (AzureLinux/CBLMariner v4+) behavior and to make a few tool interactions more robust (chrony parsing, kdump tool selection, process killing, and modprobe reload reconnect behavior).
Changes:
- Treat CBLMariner/AzureLinux v4+ as Fedora-like for kdump and dhclient timeout discovery (NetworkManager path).
- Improve Chrony tracking validation by loosening the Leap Status match to work across output variants.
- Make
Kill.by_name()resolve PIDs viapgrepfirst (withpidoffallback), and reset the node connection on modprobe reload retry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lisa/tools/modprobe.py | On reload retry, closes the node connection to force a fresh SSH transport on the next attempt. |
| lisa/tools/kill.py | Switches “kill by name” flow to PID discovery via pgrep, with pidof fallback. |
| lisa/tools/kdump.py | Routes AzureLinux/CBLMariner v4+ to the Fedora kdump implementation; broadens Fedora installer assertion. |
| lisa/tools/dhclient.py | Adds CBLMariner handling for DHCP timeout logic, using NetworkManager for v4+. |
| lisa/tools/chrony.py | Updates leap-status detection to be more tolerant and uses search() instead of match(). |
bhagyapathak
force-pushed
the
bhagya/azlinux4-support
branch
from
cd8a059 to
955ec65
Compare
✅ AI Test Selection — PASSED6 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
Comment on lines
+25
to
+29
| # Find PIDs via pgrep (matches by process name), then kill each PID | ||
| # individually to avoid the shell interpreting the name as a job spec. | ||
| pgrep = self.node.tools[Pgrep] | ||
| processes = pgrep.get_processes(process_name) | ||
| if processes: |
Contributor
There was a problem hiding this comment.
Fixed in the latest commit — by_name now tries pidof first for exact-name matching, and only falls back to pgrep when pidof finds nothing.
bhagyapathak
force-pushed
the
bhagya/azlinux4-support
branch
from
955ec65 to
9d79a0e
Compare
✅ AI Test Selection — PASSED3 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results